Add a sentinel error for missing KV secrets #16699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a sentinel error value
ErrSecretNotFound
. With this change, callers can check specifically for non-existing secrets:An example where this would be useful is when implementing an "upsert" behavior, as suggested in #16483. The caller can check the error returned from
KVv2.Patch
forerrors.Is(err, vault.ErrSecretNotFound)
and callKvV2.Put
accordingly.