Populate the running SHA256 of plugins in the mount and auth tables #17217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
approved these changes
Sep 19, 2022
Comment on lines
+262
to
+281
| if raw.(*routeEntry).mountEntry.RunningSha == "" { | ||
| t.Errorf("Expected RunningSha to be present: %+v", raw.(*routeEntry).mountEntry.RunningSha) |
There was a problem hiding this comment.
Is there a way to check that the running sha is the one that was submitted?
There was a problem hiding this comment.
We just copy the runningSha from the requested SHA, since there isn't much of a need to compute it again.
tomhjp
reviewed
Sep 20, 2022
swenson
force-pushed
the
populate-running-sha
branch
from
61138c5
to
a106bc2
Compare
tomhjp
approved these changes
Sep 21, 2022
|
Thanks! |
swenson
pushed a commit
that referenced
this pull request
Sep 21, 2022
Check if plugin version matches running version When registering a plugin, we check if the request version matches the self-reported version from the plugin. If these do not match, we log a warning. This uncovered a few missing pieces for getting the database version code fully working. We added an environment variable that helps us unit test the running version behavior as well, but only for approle, postgresql, and consul plugins. Return 400 on plugin not found or version mismatch Populate the running SHA256 of plugins in the mount and auth tables (#17217)
This was referenced Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #17182 and probably conflicts with #17171, but I can rebase when one or both of those are merged.