Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Plugins: Auto version selection for auth/secrets + tune version into release/1.12.x #17273

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17167 to be assessed for backporting due to the inclusion of the label backport/1.12.x.

The below text is copied from the body of the original PR.


Two main features:

  • Auto version selection for auth/secret engines when versioned plugins are registered
  • Add the ability to tune plugin version for auth/secret engines so that in-place upgrades can be performed

Other changes:

  • external_plugin_test.go moves the calling code a level up the stack, using the system backend's HandleRequest instead of directly calling the implementation functions for each route. Moves the tests slightly closer to production call stacks.

There's still some more follow-up work to do in future PRs, including:

  • Website documentation
  • Add -plugin-version flag to vault auth tune and vault secrets tune
  • Replace version with plugin_version everywhere (I excluded that from this PR to avoid diff noise) Done in Plugins: Consistently use plugin_version #17171
  • Take a holistic look at the changelogs for this set of features

Overview of commits

@tomhjp tomhjp enabled auto-merge (squash) September 22, 2022 13:42
@tomhjp tomhjp merged commit 69fe947 into release/1.12.x Sep 22, 2022
@tomhjp tomhjp deleted the backport/plugin-auto-version-and-upgrade/mentally-fit-gazelle branch September 19, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants