-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade vault-plugin-auth-azure to v0.13.0 #19077
Conversation
changelog/19077.txt
Outdated
@@ -0,0 +1,6 @@ | |||
```release-note:feature | |||
auth/azure: Adds support for rotate root to Azure Auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't sure if I should list all the other features added or just the latest one. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if they are all being added to 1.13 and there's no previous changelog entry for them, it makes sense to add them all now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say list all of the features/improvements/fixes that are being brought in at this time. I'd say you can leave the dependency upgrade entry out of the Vault changelog though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, there is a specific format for "feature" changelog entries. I don't believe these conform to the format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks for the clarification, @austingebauer! Updated the changelog to match the desired format for multiple features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Upgrades the Auth Azure plugin to
v0.13.0
Steps: