Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remount for mounts with spaces in the name #19585

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Fix remount for mounts with spaces in the name #19585

merged 5 commits into from
Mar 16, 2023

Conversation

VioletHynes
Copy link
Contributor

@VioletHynes VioletHynes commented Mar 16, 2023 •
edited
Loading

Context:

  • We made a change to avoid trailing spaces in mount names for remount here (as mounts cannot have trailing spaces): Fixes from mount move testing #14492
  • We instead made the change to any and all spaces in mount names
  • Mount names can have spaces in them, so this was a breaking change, and there was no reason for us to remove this behaviour

Fixes #18236

@VioletHynes VioletHynes added this to the 1.14 milestone Mar 16, 2023
@VioletHynes VioletHynes marked this pull request as ready for review March 16, 2023 18:17
akshya96
akshya96 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@akshya96 akshya96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@VioletHynes VioletHynes merged commit b48e826 into main Mar 16, 2023
@VioletHynes VioletHynes deleted the violethynes/fix-vault-secrets-move-whitespace branch March 16, 2023 19:27
This was referenced Mar 16, 2023
Merged
Merged
Merged
raymonstah pushed a commit that referenced this pull request Mar 17, 2023
@VioletHynes @raymonstah
Fix remount for mounts with spaces in the name (#19585)
8ddea0b 
* Fix remount for mounts with spaces in the name

* Git mishap

* Git mishap

* Changelog

* Godocs for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshya96 akshya96 akshya96 approved these changes

@peteski22 peteski22 Awaiting requested review from peteski22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.

Vault secrets move fails due to whitespace
2 participants
@VioletHynes @akshya96