Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add tests for PKI endpoint authentication via OpenAPI into release/1.11.x #19711

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19704 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Schema validation in IfModifiedSince appears broken, so I'm disabling it for now until the schema validation tests can be updated to support reading 304 status correctly.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/cipherboy-add-tests-pki-authing/wrongly-optimal-pheasant branch from 947beba to f8fc928 Compare March 23, 2023 15:54
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/cipherboy-add-tests-pki-authing/wrongly-optimal-pheasant branch from f8fc928 to 947beba Compare March 23, 2023 15:54
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 23, 2023

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Skipping most OpenAPI tests as fix on 1.13 wasn't backported.

See also: #18554

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
@cipherboy cipherboy force-pushed the backport/cipherboy-add-tests-pki-authing/wrongly-optimal-pheasant branch from 603fe35 to 7f35122 Compare March 23, 2023 15:55
@cipherboy cipherboy marked this pull request as ready for review March 23, 2023 15:55
@cipherboy cipherboy enabled auto-merge (squash) March 23, 2023 15:56
@cipherboy cipherboy merged commit 36709b9 into release/1.11.x Mar 23, 2023
@cipherboy cipherboy deleted the backport/cipherboy-add-tests-pki-authing/wrongly-optimal-pheasant branch April 21, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants