From a2904a5690d9b2d17d82f16a99fda7af2e275c15 Mon Sep 17 00:00:00 2001 From: Kuba Wieczorek Date: Mon, 3 Apr 2023 15:58:18 +0100 Subject: [PATCH] Ensure tests-completed job fails if required jobs either fail or are cancelled Otherwise, the tests-completed job should succeed, including when the test-ui job is skipped. --- .github/workflows/ci.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cecb2b9cebdc..10a963012453 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -283,10 +283,8 @@ jobs: - setup - test-go - test-ui - if: | - always() && - !contains(needs.*.result, 'failure') && - !contains(needs.*.result, 'cancelled') + if: always() runs-on: ${{ fromJSON(needs.setup.outputs.compute-tiny) }} steps: - - run: echo "All Go tests successfully passed" + - run: | + tr -d '\n' <<< '${{ toJSON(needs.*.result) }}' | grep -q -v -E '(failure|cancelled)'