UI: fix browser console formatting #20064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
commented
Apr 10, 2023
| <p class="console-ui-command is-font-mono"><Icon @name="chevron-right" />{{@content}}</p> |
There was a problem hiding this comment.
<pre> made the command to appear on a separate line, below the icon
hellobontempo
commented
Apr 10, 2023
| @@ -1,8 +1,10 @@ | |||
| <div class="console-ui-output has-copy-button"> | |||
| <pre>Keys | |||
| <pre> | |||
| Keys | |||
There was a problem hiding this comment.
aligns list items (previously, first key was not indented enough)
hellobontempo
commented
Apr 10, 2023
Monkeychip
reviewed
Apr 10, 2023
| <p class="console-ui-command is-font-mono"><Icon @name="chevron-right" />{{@content}}</p> |
Monkeychip
approved these changes
Apr 10, 2023
This was referenced Apr 11, 2023
zofskeez
reviewed
Apr 11, 2023
| @@ -47,7 +47,7 @@ module.exports = { | |||
| }, | |||
| 'require-input-label': 'off', | |||
| }, | |||
| ignore: ['lib/story-md', 'tests/**'], | |||
| ignore: ['lib/story-md', 'tests/**', 'app/templates/components/console/*'], | |||
There was a problem hiding this comment.
I wonder if it would be better to use a block quote to disable the specific rule in the file? This disables linting for all the files in that directory which then wouldn't catch any other errors.
hellobontempo
added a commit
that referenced
this pull request
Apr 11, 2023
* fix console formatting for help output * fix again * fix again * fix, add to ignore * fix, add to ignore * add to ignore file * fix formatting, no verify * remove lib/story.md * add changelog * hold off updating ignore list for separate ticket * fix test
hellobontempo
added a commit
that referenced
this pull request
Apr 11, 2023
* fix console formatting for help output * fix again * fix again * fix, add to ignore * fix, add to ignore * add to ignore file * fix formatting, no verify * remove lib/story.md * add changelog * hold off updating ignore list for separate ticket * fix test
hellobontempo
added a commit
that referenced
this pull request
Apr 12, 2023
* UI: fix browser console formatting (#20064) * fix console formatting for help output * fix again * fix again * fix, add to ignore * fix, add to ignore * add to ignore file * fix formatting, no verify * remove lib/story.md * add changelog * hold off updating ignore list for separate ticket * fix test * UI/add prettier ignore for ui console file (#20094) * fix template-lintrc file * add prettier ignore
hellobontempo
added a commit
that referenced
this pull request
Apr 12, 2023
* UI: fix browser console formatting (#20064) * fix console formatting for help output * fix again * fix again * fix, add to ignore * fix, add to ignore * add to ignore file * fix formatting, no verify * remove lib/story.md * add changelog * hold off updating ignore list for separate ticket * fix test * UI/add prettier ignore for ui console file (#20094) * fix template-lintrc file * add prettier ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the Ember upgrade to 3.24 we implemented some linting changes that inadvertently affected the browser console’s output. Each command should be on a separate line. Fixes #19568
before
after fix
>(not on line below)