Backport of sdk/ldaputil: add connection_timeout configurable into release/1.13.x #20148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ldap-dial-timeout/hopefully-proper-mouse
branch
from
9b81c24
to
7cec617
Compare
|
|
* sdk/ldaputil: add connection_timeout configurable * changelog * Update doc * Fix test * Change default to 30s
jasonodonnell
force-pushed
the
backport/ldap-dial-timeout/hopefully-proper-mouse
branch
from
6e75042
to
146e6bd
Compare
jasonodonnell
approved these changes
Apr 13, 2023
jasonodonnell
deleted the
backport/ldap-dial-timeout/hopefully-proper-mouse
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20144 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
The go-ldap package sets a 60 second timeout in their package for dial attempts which aligns with Vault's 60 second client timeout. Since these timeouts are the same if the first value in our LDAP config
urlis unavailable, no other URLs in the list will be tried and all connections will fail.This adds a new LDAP config
connection_timeoutwhich allows operators to override this timeout value. By setting this value lower you can leverage the backup URLs in the config.This is not the same as the existing config
request_timeoutwhich tunes timeout values after a connection is made to LDAP.A workaround exists where clients can set
VAULT_CLIENT_TIMEOUT. By adding this config though we can set timeouts for all user connections and may be a better overall experience.Overview of commits