VAULT-15668: fix windows issues with -dev-tls flag #20257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miagilepner
force-pushed
the
miagilepner/VAULT-15668-devtls-windows
branch
from
577aee6
to
fe2455c
Compare
miagilepner
changed the title
mpalmi
approved these changes
Apr 20, 2023
This was referenced Apr 21, 2023
miagilepner
added a commit
that referenced
this pull request
Apr 21, 2023
* fix -dev-tls flag on windows * changelog * fix only hcl config * fix import * fmt
miagilepner
added a commit
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -dev-tls command wasn't working on windows, because the filepaths in the hcl config had unescaped backslashes. This PR adds escaping.
I also tested the changes on a windows VM, and confirmed that they resolved the problem.
Closes #20038