Backport of Replace all remaining time.ParseDurations with parseutil.ParseDurationSeconds into release/1.14.x #21362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21357 to be assessed for backporting due to the inclusion of the label backport/1.14.x.
The below text is copied from the body of the original PR.
Vault's duration string format supports a strict superset of options compared to Go's duration string format: https://developer.hashicorp.com/vault/docs/concepts/duration-format
In particular, we support days, e.g.
5d
, whereastime.ParseDuration
does not.We use
parseutil.ParseDurationSeconds
everywhere in the code we can, to support our advertised duration format and to be consistent with ourselves. The majority of our code already usesparseutil.ParseDurationSeconds
, but there were a few places I found thattime.ParseDuration
was still being used as part of poking around, so I thought I'd fix them all at once.I'm not worried about the fact this change changes a lot of files.
ParseDurationSeconds
is battle-tested, and there's no valid duration thattime.ParseDuration
supports that we don't also support.Overview of commits