Backport of UI: catch error when verifying certificates with unsupported signature algorithms into release/1.14.x #21931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-18198/catch-verify-error-for-ed25519-key-types/physically-outgoing-airedale
branch
from
a13cf98
to
5e3def6
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-18198/catch-verify-error-for-ed25519-key-types/physically-outgoing-airedale
branch
from
a57166c
to
5e1ac0c
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
approved these changes
Jul 19, 2023
hellobontempo
deleted the
backport/ui/VAULT-18198/catch-verify-error-for-ed25519-key-types/physically-outgoing-airedale
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21926 to be assessed for backporting due to the inclusion of the label backport/1.14.x.
The below text is copied from the body of the original PR.
The pki.js library doesn't support the
ed25519key type source code so ourverify()function was failing when checking whether or not a certificate is a root.This wraps the verify function in a
try...catchso if the verify function fails, we instead check the authority key ID includes the signature key ID.Overview of commits