identity/tokens: adds plugin issuer with openid-configuration and keys #24898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
vinay-gopalan
approved these changes
Jan 17, 2024
austingebauer
added a commit
that referenced
this pull request
Jan 17, 2024
#24898) * identity/tokens: adds plugin issuer with openid-configuration and keys * adds changelog * typo in comment * adds go doc to tests for linter
austingebauer
added a commit
that referenced
this pull request
Jan 29, 2024
#24898) * identity/tokens: adds plugin issuer with openid-configuration and keys * adds changelog * typo in comment * adds go doc to tests for linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an openid-configuration and keys API for a new plugin token issuer. The issuer will only be capable of internally issuing tokens to Vault plugins for workload identity federation exchanges.
The issuer will provide unauthenticated APIs with the following paths:
/v1/identity/oidc/plugins/.well-known/openid-configuration/v1/identity/oidc/plugins/.well-known/keysThe approach makes the "plugins" segment above optional so that we can serve both the identity token issuer and plugin token issuer APIs using the same request handlers. I've called these "child" issuers, but I'm happy to consider a different name. It sets up the implementation for easily adding more child issuers if a use case ever comes up.
I ran all OIDC-related tests successfully using
go test -run=TestOIDC. Documentation will be added in a follow-up PR.