Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Transit: Release locks using defer statements into release/1.13.x #25341

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #25336 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.


  • Leverage defer statements to Unlock the fetched policy to avoid issues with forgetting to manually Unlock during each return statement

Fixes: #25325


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/vault-23960-transit-error-deadlock/widely-accepted-walleye branch from 8afbf5d to 62bcbe0 Compare February 9, 2024 19:06
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 9, 2024
@stevendpclark stevendpclark self-assigned this Feb 9, 2024
@stevendpclark stevendpclark added this to the 1.13.14 milestone Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Feb 9, 2024

CI Results:
All Go tests succeeded! ✅

@stevendpclark
Copy link
Contributor

Closing as it seems we aren't creating another 1.13.x release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants