UI: Fix kubernetes auth method role management #25999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
commented
Mar 18, 2024
| @@ -29,5 +29,10 @@ | |||
| {{/each}} | |||
|
|
|||
| <div class="field is-grouped box is-fullwidth is-bottomless"> | |||
| <Hds::Button @text="Cancel" @color="secondary" @route="vault.cluster.secrets.backends" /> | |||
There was a problem hiding this comment.
Small bug I noticed when testing, we were only going to the secret engine list on cancel
hellobontempo
commented
Mar 18, 2024
| @@ -5,7 +5,9 @@ | |||
|
|
|||
| import { helper as buildHelper } from '@ember/component/helper'; | |||
|
|
|||
| const MANAGED_AUTH_BACKENDS = ['cert', 'userpass', 'ldap', 'okta', 'radius']; | |||
There was a problem hiding this comment.
alphabetized, but also added 'kubernetes'
|
Build Results: |
|
CI Results: |
…of all auth methods you can log in with
hashishaw
deleted the
ui/VAULT-25070/fix-kubernetes-auth-role-management
branch
This was referenced Mar 18, 2024
hashishaw
added a commit
that referenced
this pull request
Mar 18, 2024
Co-authored-by: Chelsea Shaw <cshaw@hashicorp.com> Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
hashishaw
added a commit
that referenced
this pull request
Mar 18, 2024
Co-authored-by: Chelsea Shaw <cshaw@hashicorp.com> Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
1 task
hashishaw
added a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a regression introduced by #25364 which accidentally hid the
rolestab in the kubernetes UI.