Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Don't show Resultant-ACL banner when wildcard policy present into release/1.15.x #26270

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #26233 to be assessed for backporting due to the inclusion of the label backport/1.15.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@hashishaw
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


This PR is to update the behavior of the Resultant ACL banner so that it no longer shows in child namespaces if the user has a "*" path in their policy.

  • Ent tests passed

How to test

To set up namespaces with some users to log in and verify the behavior, run the following script:

# create namespace
vault namespace create admin
vault namespace create -namespace=admin child

# create policies
vault policy write root-admin - <<EOF
path "*" {
capabilities = ["read", "list", "create", "update", "delete"]
}
EOF
vault policy write -namespace=admin admin - <<EOF
path "*" {
capabilities = ["read", "list", "create", "update", "delete"]
}
EOF

# create users
vault auth enable userpass
vault write auth/userpass/users/root password=password policies=root-admin
vault auth enable -namespace=admin userpass
vault auth tune -namespace=admin -listing-visibility="unauth" userpass
vault write -namespace=admin auth/userpass/users/admin password=password policies=admin

Test 1

  • Log into root namespace with root username
  • resultant-acl banner is not rendered
  • Navigate to admin namespace
    - Previously, resultant-acl banner would show but with these changes it does not
  • Change namespace in url to some namespace that does not exist (eg "foo")
    - Previously, resultant-acl banner would show but with these changes it does not

Test 2

  • Log into admin namespace with admin username
  • resultant-acl banner is not rendered
  • Navigate to child namespace
    - Previously, resultant-acl banner would show but with these changes it does not
  • Change namespace in url to some namespace that does not exist (eg "foo")
  • Resultant-acl banner should show

Before
image

After
image

This PR also updates the Resultant-ACL banner so that it only shows when a user has a non-expired token.


Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 4, 2024
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

github-actions bot commented Apr 4, 2024

CI Results:
All Go tests succeeded! ✅

@hashishaw
Copy link
Contributor

Closed in favor of #26271

@hashishaw hashishaw closed this Apr 11, 2024
@hashishaw hashishaw deleted the backport/ui/VAULT-24544/hide-resultant-acl-when-wildcard-policy/scarcely-rare-grizzly branch April 11, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants