Backport of pass nil function when no externalID (this matches old functionality) into release/1.17.x #28034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/VAULT-28853/handle-blank-externalID/distinctly-flexible-goblin
branch
from
a7cfb96 to
1b1f5b3
Compare
hc-github-team-secure-vault-core
requested a review
from a team
as a code owner
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
tomcf-hcp
approved these changes
Aug 8, 2024
kpcraig
deleted the
backport/VAULT-28853/handle-blank-externalID/distinctly-flexible-goblin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #27858 to be assessed for backporting due to the inclusion of the label backport/1.17.x.
The below text is copied from the body of the original PR.
Pass a nil function when the externalID is empty.
This fixes an issue where AWS would reject a blank externalID as too short, presumably because we were passing a non-nil value.
Overview of commits