UI - Update Client Count filtering #28036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass namespace from url param to adapter * Add helper method on namespace service for calculating full namespace path * add adapter test coverage, update counts route TS * update selectors, add test coverage for new functionality
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
* Add filtering to mirage data based on namespace header * use filtering on custom acme CC test * fix filtering logic
* remove unused arg newUsageCounts * update filterActivityResponse to use a deep copy of the data * move export-button to clients/page-header component * Use page-header on clients counts page * remove export concerns from attribution component * remove unused arg * remove unused getter * add copyright * address PR comments
* move overview-only attrs to overview component * update types, make the static data make sense * update month block types * Update attribution component with tests * update overview component and tests * cleanup * copy updates + cleanup * more cleanup * fix tests
* add filterByMonthDataForMount util method * remove namespaces_by_key usages, tests, and related util 🎉 * remove unused * test coverage for filterByMonthDataForMount * remove average clients from pages, fix acme tests * fix tests, fix no data date range on load, update function so it makes a copy of data * consolidate filtered totals logic * remove log * clean
* always show both namespace and mount filters * Only show filters section if there exist mount attribution (aka there is data to filter) * Update filter placeholders to reflect current namespace * Update overview component & test * update page::counts test and behavior * cleanup * fix test for community + no start date * Add header * tidy * address PR comment
* copy from stacked chart * grouping works on bar chart * fix colors and add legend * Add upgrade info to tooltip * Use grouped bar chart instead of line on running totals * initial test * update grouped bar chart + tests * remove line chart * fix colors and attributes * fix other tests * more test cleanup * Skip warning message from client count API on dashboard only * add assertion that warning shows up for default date range * update export button to hide when no data * cleanup dashboard test * Add copyright * add application adapter test * ugh copyright
|
Build Results: |
This was referenced Sep 6, 2024
This was referenced Sep 11, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Client Count dashboard in a number of ways, including:
setting a namespace filter will re-query the API with the namespace added as a header, and the counts reflect the selected namespace and its children
you no longer need to apply a namespace filter before applying a mount filter. Mounts shown reflect the selected namespace filter OR the current namespace
attribution for child namespaces and mount paths within the current (filtered) namespace are shown unless there is no data OR the data is filtered at the mount level
Main client counts chart on overview page is updated to a grouped bar chart showing total v new clients
Export button is moved to the page header, and now queries the activity export API. It is hidden if there is no data for the date range & namespace, or if the user does not have sudo capabilities on the export endpoint.
Ent tests pass
Screenshots
Within a namespace:
