This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Add-on updates #4879
Merged
Add-on updates #4879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Add gateway.yml entry for update endpoint. AddOnEvent will handle events for all operations on Add-ons, which includes creation, destruction, and modification. This commit also includes an update to the state test for events.
paladin-devops
added
the
pr/no-changelog
izaaklauer
reviewed
Aug 15, 2023
| // Update Add-on | ||
| updatedAddOn, err := s.AddOnUpdate(ctx, | ||
| &pb.AddOn{ | ||
| Name: "your friendly updated neighborhood add-on", |
izaaklauer
suggested changes
Aug 15, 2023
| }, | ||
| ) | ||
| require.NoError(err) | ||
| require.NotNil(updatedAddOn) |
There was a problem hiding this comment.
Can we do another get after the update, to check that the updated properties are being returned?
catsby
approved these changes
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add endpoint to support updating Add-ons.