Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output of running fourmolu sometimes doesn't appear in the GitHub Action logs #4

Closed
cdepillabout opened this issue Jun 14, 2022 · 2 comments · Fixed by #6
Closed

output of running fourmolu sometimes doesn't appear in the GitHub Action logs #4

cdepillabout opened this issue Jun 14, 2022 · 2 comments · Fixed by #6
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@cdepillabout
Copy link
Collaborator

cdepillabout commented Jun 14, 2022

It is incredibly difficult today to determine where the fault lies in the codebase, since the Action doesn't say anything about which files are not formatted, neither in the files view, nor in the action interface

Screenshot_20220611_223009

This is the faulty run

Originally posted by @tchoutri in #1 (comment)


As shown above in https://github.com/flora-pm/flora-server/runs/6845560053?check_suite_focus=true, it does appear that this fourmolu action is not correctly outputting which files are not formatted correctly.

@cdepillabout
Copy link
Collaborator Author

I created a test PR on this repo just to make sure that the fourmolu-action does correctly give warnings in #5. It appears to work as expected.

@tchoutri I took a look at your job, and the one suspicious thing I noticed is that you aren't calling the checkout action anywhere:

https://github.com/flora-pm/flora-server/blob/45d3c8a0fabf540e0b8086a12c354b3358bc5620/.github/workflows/linting.yml#L9-L17

You'll likely need the checkout action as well just so the fourmolu action can see your Haskell source code?

https://github.com/flora-pm/flora-server/blob/45d3c8a0fabf540e0b8086a12c354b3358bc5620/.github/workflows/linting.yml#L22

I imagine we need a "full" example in the README that can easily be copy-pasted.

@tchoutri
Copy link

tchoutri commented Jun 14, 2022

@cdepillabout haha you're right, this was indeed the problem! It's just that the failure mode wasn't hinting at it. :) I consider this issue closed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants