Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Revert "Compilation warnings on OpenBSD" #373

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cbits/decaf/include/decaf/point_448.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ extern "C" {
/** @brief Galois field element internal structure */
typedef struct cryptonite_gf_448_s {
cryptonite_decaf_word_t limb[512/CRYPTONITE_DECAF_WORD_BITS];
} __attribute__((aligned(16))) cryptonite_gf_448_s, cryptonite_gf_448_t[1];
} __attribute__((aligned(32))) cryptonite_gf_448_s, cryptonite_gf_448_t[1];
#endif /* __CRYPTONITE_DECAF_448_GF_DEFINED__ */
/** @endcond */

Expand Down
2 changes: 1 addition & 1 deletion cbits/decaf/p448/f_field.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#define SER_BYTES 56
typedef struct cryptonite_gf_448_s {
word_t limb[NLIMBS];
} __attribute__((aligned(16))) cryptonite_gf_448_s, cryptonite_gf_448_t[1];
} __attribute__((aligned(32))) cryptonite_gf_448_s, cryptonite_gf_448_t[1];

#define GF_LIT_LIMB_BITS 56
#define GF_BITS 448
Expand Down
14 changes: 0 additions & 14 deletions cbits/decaf/tools/generate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@
# * code related to SHAKE is replaced by cryptonite code, referenced from
# a custom shake.h. As a consequence, portable_endian.h is not needed.
#
# * aligned(32) attributes used for stack alignment are replaced by
# aligned(16). This removes warnings on OpenBSD with GCC 4.2.1, and makes
# sure we get at least 16-byte alignment. 32-byte alignment is necessary
# only for AVX2 and arch_x86_64, which we don't have.
#
# * visibility("hidden") attributes are removed, as this is not supported
# on Windows/MinGW, and we have name mangling instead
#
Expand All @@ -49,19 +44,10 @@ fi

convert() {
local FILE_NAME="`basename "$1"`"
local REPL

if [ "$FILE_NAME" = word.h ]; then
REPL='__attribute__((aligned(32)))'
else
REPL='__attribute__((aligned(16)))'
fi

sed <"$1" >"$2/$FILE_NAME" \
-e 's/ __attribute((visibility("hidden")))//g' \
-e 's/ __attribute__((visibility("hidden")))//g' \
-e 's/ __attribute__ ((visibility ("hidden")))//g' \
-e "s/__attribute__((aligned(32)))/$REPL/g" \
-e 's/decaf_/cryptonite_decaf_/g' \
-e 's/DECAF_/CRYPTONITE_DECAF_/g' \
-e 's/gf_/cryptonite_gf_/g' \
Expand Down