bumped cabal-version field #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we change it in the sub projects cabal file, such as servant-swagger.cabal for instance? |
|
I think we should |
teto
force-pushed
the
bump-cabal-version
branch
from
ccbfb85 to
5c914e9
Compare
|
I've done the requested change. Failures dont seem linked to PR ? |
|
It seems that some other Cabal files have been forgotten (non-exhaustive list) :
|
Are still missing... |
tchoutri
requested changes
Dec 27, 2021
akhesaCaro
reviewed
Dec 27, 2021
also need to be updated... |
added 2 commits
December 27, 2021 16:05
Cabal supports two types of licenses, native and SPDX, which can be seen here hackage.haskell.org/package/Cabal-3.6.2.0/docs/Distribution-Types-PackageDescription.html#v:licenseRaw Several packages use BSD-3-Clause as a license, in conjonction with cabal-version: >=1.10 which cabal parses as Right (UnknownLicense "BSD-3"). If I change teh cabal-version to cabal-version: 2.2 , cabal correctly identifdies the license License (ELicense (ELicenseId BSD_3_Clause)).
aka BSD3 -> BSD-3-Clause: next cabal may deprecate the old format
teto
force-pushed
the
bump-cabal-version
branch
from
7bd4fe8 to
d284832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1497