Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attoparsec-aeson dependency #1687

Closed

Conversation

9999years
Copy link

@9999years 9999years commented Jun 20, 2023

This makes servant buildable with the upcoming aeson-2.2 release.

@9999years 9999years force-pushed the add-attoparsec-aeson branch from 5cb44f9 to f282baf Compare June 20, 2023 20:26
@tchoutri
Copy link
Contributor

@9999years Hi! Is there a reason why you wish to add attoparsec-aeson to the dependencies of servant? :)

@9999years
Copy link
Author

Yes, it's for the upcoming aeson-2.2 release, which moves the Data.Aeson.Parser module from aeson to attoparsec-aeson.

src/Servant/API/ContentTypes.hs:79:1: error:
    Could not find module ‘Data.Aeson.Parser’
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
79 | import           Data.Aeson.Parser
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

aeson-2.2 isn't released yet, so we don't need to merge this yet, but I'm working on supporting it internally and created this PR to reference in our build.

@tchoutri
Copy link
Contributor

I see, thank you :)

georgefst added a commit to georgefst/spotify that referenced this pull request Jul 1, 2023
We can't yet bump `aeson` due to `servant` - haskell-servant/servant#1687.
@ysangkok
Copy link
Contributor

Thanks for the contribution, but we merged #1695 instead, so this is no longer necessary.

@ysangkok ysangkok closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants