Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GHC 9.10 #1765

Merged
merged 3 commits into from
Jun 22, 2024
Merged

Allow GHC 9.10 #1765

merged 3 commits into from
Jun 22, 2024

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Jun 5, 2024

This is related to #1753, but adds a bunch of allow-newers. There are so many
dependencies of servant, that it will take a long time for all of them to
catch up. To make sure GHC 9.10 keeps working in this repo, let's test with
these allow-newers. Released packages won't have these bound overrides, of
course.

@ysangkok
Copy link
Contributor Author

ysangkok commented Jun 5, 2024

I thought the failure was because of the colors, but it still fails locally with this snippet added to cabal.project:

if(impl(ghc >= 9.10.1))                                                             
  package servant                                                                   
    ghc-options: -fdiagnostics-color=never

See flag reference

@ysangkok ysangkok marked this pull request as draft June 5, 2024 17:11
@ysangkok
Copy link
Contributor Author

This is the error in case the CI logs get deleted:

src/Servant/API/TypeLevel.hs:270: failure in expression `instance AtMostOneFragment FailAPI'
expected: ...
          ...Only one Fragment allowed per endpoint in api...
          ...
          ...In the instance declaration for...
 but got: <interactive>:6[39](https://github.com/haskell-servant/servant/actions/runs/9387799345/job/25851582146#step:10:40):10: error: [GHC-64725]
              • Only one Fragment allowed per endpoint in api ‘Fragment Bool
                                                               :> (Fragment Int :> Get '[JSON] NoContent)’.
          .................................................................................O^
              • In the instance declaration for ‘AtMostOneFragment FailAPI’

allow-newer: file-embed-lzma:base
allow-newer: file-embed-lzma:template-haskell
allow-newer: file-embed-lzma:filepath
allow-newer: lzma:base
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was already bumped on hackage: https://hackage.haskell.org/package/lzma

allow-newer: postgresql-simple:base
allow-newer: postgresql-simple:template-haskell
allow-newer: postgresql-simple:containers
allow-newer: postgresql-libpq:base
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +89 to +91
allow-newer: swagger2:template-haskell
allow-newer: swagger2:lens
allow-newer: swagger2:containers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +84 to +85
allow-newer: insert-ordered-containers:base
allow-newer: insert-ordered-containers:lens
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysangkok ysangkok marked this pull request as ready for review June 22, 2024 16:12
@ysangkok ysangkok merged commit 3d37521 into master Jun 22, 2024
8 checks passed
@ysangkok ysangkok deleted the allow-ghc-9.10 branch June 22, 2024 16:12
@ysangkok ysangkok mentioned this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants