From 3545f2bcc86d5a96223e53341d927f426f6dd970 Mon Sep 17 00:00:00 2001
From: Javier Sagredo <jasataco@gmail.com>
Date: Tue, 16 Jul 2024 11:50:22 +0200
Subject: [PATCH] Remove read-only in `cabal clean` on Windows

---
 .../src/Distribution/Client/CmdClean.hs       | 21 ++++++++++++++++++-
 changelog.d/pr-10190                          | 11 ++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)
 create mode 100644 changelog.d/pr-10190

diff --git a/cabal-install/src/Distribution/Client/CmdClean.hs b/cabal-install/src/Distribution/Client/CmdClean.hs
index 2ffda4dce6a..4a32d0bb0fd 100644
--- a/cabal-install/src/Distribution/Client/CmdClean.hs
+++ b/cabal-install/src/Distribution/Client/CmdClean.hs
@@ -52,6 +52,10 @@ import Distribution.Simple.Utils
   , info
   , wrapText
   )
+import Distribution.System
+  ( OS (Windows)
+  , buildOS
+  )
 import Distribution.Utils.Path hiding
   ( (<.>)
   , (</>)
@@ -60,6 +64,9 @@ import Distribution.Verbosity
   ( normal
   )
 
+import Control.Exception
+  ( throw
+  )
 import Control.Monad
   ( forM
   , forM_
@@ -78,6 +85,10 @@ import System.Directory
 import System.FilePath
   ( (</>)
   )
+import System.IO.Error
+  ( isPermissionError
+  )
+import qualified System.Process as Process
 
 data CleanFlags = CleanFlags
   { cleanSaveConfig :: Flag Bool
@@ -168,7 +179,15 @@ cleanAction (ProjectFlags{..}, CleanFlags{..}) extraArgs _ = do
         let distRoot = distDirectory distLayout
 
         info verbosity ("Deleting dist-newstyle (" ++ distRoot ++ ")")
-        handleDoesNotExist () $ removeDirectoryRecursive distRoot
+        handleDoesNotExist () $ do
+          if buildOS == Windows
+             then do
+               -- Windows can't delete some git files #10182
+               void $ Process.createProcess_ "attrib" $ Process.shell $ "attrib -s -h -r " <> distRoot <> "\\*.* /s /d"
+               catch
+                 (removeDirectoryRecursive distRoot)
+                 (\e -> if isPermissionError e then removeDirectoryRecursive distRoot else throw e)
+             else removeDirectoryRecursive distRoot
 
     removeEnvFiles $ distProjectRootDirectory distLayout
 
diff --git a/changelog.d/pr-10190 b/changelog.d/pr-10190
new file mode 100644
index 00000000000..d9e4f009b94
--- /dev/null
+++ b/changelog.d/pr-10190
@@ -0,0 +1,11 @@
+synopsis: Fix `cabal clean` permissions on Windows
+packages: cabal-install
+prs: #10190
+issues: #10182
+significance:
+
+description: {
+
+- `cabal clean` now removes the read-only mark recursively in the `dist-newstyle` folder on Windows before attempting to delete it.
+
+}