Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap plans still contain hashable-1.4.6.0 with +arch-native #10146

Closed
TerrorJack opened this issue Jun 24, 2024 · 7 comments · Fixed by #10148
Closed

Bootstrap plans still contain hashable-1.4.6.0 with +arch-native #10146

TerrorJack opened this issue Jun 24, 2024 · 7 comments · Fixed by #10148

Comments

@TerrorJack
Copy link
Collaborator

Before the new release goes out, you might also want to update bootstrap json plans to ensure hashable-1.4.6.0 is not contained in the bootstrap plans, maybe also bumping the hashable lower bound?

Related: #9885 #10142

@geekosaur
Copy link
Collaborator

Bootstrap plans aren't part of the release.

@geekosaur
Copy link
Collaborator

More to the point, we've punted on bootstrap plans for 9.10.1 because we want to release before hackage-server is likely to release a compatible version, so bootstrap is going to be hobbled anyway.

@Mikolaj
Copy link
Member

Mikolaj commented Jun 24, 2024

I think it's fine if bootstraps don't support the newest GHC. The original purpose was to bootstrap to new architectures and using the newest GHC is only asking for trouble (unless it's the only one supporting the architecture). Similarly, Linux distributions never use the newest GHC.

BTW, is hashable-1.4.6.0 actually a part of any of the existing boostrap plans on branch master? It can't be, I guess?

@TerrorJack
Copy link
Collaborator Author

Bootstrap plans aren't part of the release.

Of course, but bootstrap plans infected with a bad revision of hashable will still bite their consumers hard (e.g. distro packagers) so it's still good to correct this particular mistake IMHO

BTW, is hashable-1.4.6.0 actually a part of any of the existing boostrap plans on branch master?

https://github.com/haskell/cabal/blob/master/bootstrap/linux-9.8.2.json#L214
https://github.com/haskell/cabal/blob/master/bootstrap/linux-9.6.4.json#L210
https://github.com/haskell/cabal/blob/master/bootstrap/linux-9.4.8.json#L240
https://github.com/haskell/cabal/blob/master/bootstrap/linux-9.2.8.json#L250
https://github.com/haskell/cabal/blob/master/bootstrap/linux-9.0.2.json#L280
https://github.com/haskell/cabal/blob/master/bootstrap/linux-8.10.7.json#L280

@geekosaur
Copy link
Collaborator

A bunch of hashable refs in the bootstrap jsons on both 3.12 and master have +arch-native.

hilfy «cabal:master» Z$ grep -A2 hashable bootstrap/*.json
bootstrap/linux-8.10.7.json:      "component": "lib:hashable",
bootstrap/linux-8.10.7.json-      "flags": [
bootstrap/linux-8.10.7.json-        "+arch-native",
--
bootstrap/linux-8.10.7.json:      "package": "hashable",
bootstrap/linux-8.10.7.json-      "revision": 0,
bootstrap/linux-8.10.7.json-      "source": "hackage",
--
bootstrap/linux-9.0.2.json:      "component": "lib:hashable",
bootstrap/linux-9.0.2.json-      "flags": [
bootstrap/linux-9.0.2.json-        "+arch-native",
--
bootstrap/linux-9.0.2.json:      "package": "hashable",
bootstrap/linux-9.0.2.json-      "revision": 0,
bootstrap/linux-9.0.2.json-      "source": "hackage",
--
bootstrap/linux-9.2.8.json:      "component": "lib:hashable",
bootstrap/linux-9.2.8.json-      "flags": [
bootstrap/linux-9.2.8.json-        "+arch-native",
--
bootstrap/linux-9.2.8.json:      "package": "hashable",
bootstrap/linux-9.2.8.json-      "revision": 0,
bootstrap/linux-9.2.8.json-      "source": "hackage",
--
bootstrap/linux-9.4.8.json:      "component": "lib:hashable",
bootstrap/linux-9.4.8.json-      "flags": [
bootstrap/linux-9.4.8.json-        "+arch-native",
--
bootstrap/linux-9.4.8.json:      "package": "hashable",
bootstrap/linux-9.4.8.json-      "revision": 0,
bootstrap/linux-9.4.8.json-      "source": "hackage",
--
bootstrap/linux-9.6.4.json:      "component": "lib:hashable",
bootstrap/linux-9.6.4.json-      "flags": [
bootstrap/linux-9.6.4.json-        "+arch-native",
--
bootstrap/linux-9.6.4.json:      "package": "hashable",
bootstrap/linux-9.6.4.json-      "revision": 0,
bootstrap/linux-9.6.4.json-      "source": "hackage",
--
bootstrap/linux-9.8.2.json:      "component": "lib:hashable",
bootstrap/linux-9.8.2.json-      "flags": [
bootstrap/linux-9.8.2.json-        "+arch-native",
--
bootstrap/linux-9.8.2.json:      "package": "hashable",
bootstrap/linux-9.8.2.json-      "revision": 0,
bootstrap/linux-9.8.2.json-      "source": "hackage",
hilfy «cabal:master» Z$ _

@geekosaur geekosaur linked a pull request Jun 24, 2024 that will close this issue
2 tasks
@Mikolaj
Copy link
Member

Mikolaj commented Jun 24, 2024

Wow, well spotted. Surprising that it's so many of them.

@geekosaur
Copy link
Collaborator

Interestingly, GitHub didn't close this issue despite recognizing the above merge that fixed this. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants