-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows tests #10186
Merged
Merged
Fix Windows tests #10186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
commented
Jul 7, 2024
cabal-testsuite/PackageTests/Backpack/Includes2/cabal-internal.test.hs
Outdated
Show resolved
Hide resolved
geekosaur
approved these changes
Jul 8, 2024
cabal-testsuite/PackageTests/GhcPkgGuess/SymlinkVersion/setup.test.hs
Outdated
Show resolved
Hide resolved
cabal-testsuite/PackageTests/PreProcess/Hsc2HsOptionsCC/setup.test.hs
Outdated
Show resolved
Hide resolved
If CI works, then this looks good to me. |
jasagredo
force-pushed
the
js/windows-tests
branch
2 times, most recently
from
July 8, 2024 23:06
52f1994
to
b0b04a8
Compare
jasagredo
commented
Jul 8, 2024
cabal-testsuite/PackageTests/ConditionalAndImport/cabal.test.hs
Outdated
Show resolved
Hide resolved
jasagredo
force-pushed
the
js/windows-tests
branch
from
July 9, 2024 10:34
b0b04a8
to
50ba047
Compare
Mikolaj
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for so much clarity and information for the future self and future us.
jasagredo
force-pushed
the
js/windows-tests
branch
2 times, most recently
from
July 15, 2024 21:48
7b08b47
to
8182712
Compare
jasagredo
commented
Jul 15, 2024
cabal-testsuite/PackageTests/TestSuiteTests/ExeV10/cabal-with-hpc.multitest.hs
Show resolved
Hide resolved
jasagredo
force-pushed
the
js/windows-tests
branch
from
July 15, 2024 22:18
8182712
to
d559f84
Compare
jasagredo
added
merge me
Tell Mergify Bot to merge
and removed
attention: needs-review
labels
Jul 15, 2024
mergify
bot
added
the
merge delay passed
Applied (usually by Mergify) when PR approved and received no updates for 2 days
label
Jul 17, 2024
Mikolaj
force-pushed
the
js/windows-tests
branch
from
July 17, 2024 22:58
d559f84
to
56a6a94
Compare
jasagredo
added
merge delay passed
Applied (usually by Mergify) when PR approved and received no updates for 2 days
and removed
merge delay passed
Applied (usually by Mergify) when PR approved and received no updates for 2 days
labels
Jul 18, 2024
Mikolaj
force-pushed
the
js/windows-tests
branch
from
July 18, 2024 17:32
56a6a94
to
4b1d9b9
Compare
Thanks for the rebase(s) @Mikolaj 😄 |
@mergify backport 3.12 |
✅ Backports have been created
|
Perhaps, this PR should have been squashed?.. |
This was referenced Jul 18, 2024
Yeah, perhaps... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merge delay passed
Applied (usually by Mergify) when PR approved and received no updates for 2 days
merge me
Tell Mergify Bot to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local+noindex
uri inwithRepo
which enables many tests on Windows (just a matter of\\ -> /
)\\ -> /
but also removingC:\\
)skip*IO
functions onIO ()
to quickly discard tests without having to setup a test env55 tests in total which were skipped or expected broken on Windows now are passing:
and
66-55=11
tests were previously being skipped and now are marked as known failure, with an issue number: