tests: Make structured hash tests invariant to GHC version #10270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpickering
force-pushed
the
wip/structured-hash-fix
branch
from
63895af to
3fb0a3d
Compare
ulysses4ever
approved these changes
Aug 21, 2024
mpickering
force-pushed
the
wip/structured-hash-fix
branch
from
3fb0a3d to
7a69615
Compare
geekosaur
approved these changes
Aug 21, 2024
mergify
bot
added
the
merge delay passed
In 9.8 the Generic instance for tuples changed (see https://gitlab.haskell.org/ghc/ghc/-/issues/24291) for more details. Therefore we remove the dependency on the `Generic` instance and the hashes will be invariant across GHC versions (for now). Fixes #10269
Mikolaj
force-pushed
the
wip/structured-hash-fix
branch
from
7a69615 to
b90ccb3
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9.8 the Generic instance for tuples changed (see https://gitlab.haskell.org/ghc/ghc/-/issues/24291) for more details.
Therefore we remove the dependency on the
Genericinstance and the hashes will be invariant across GHC versions (for now).Fixes #10269
Please read Github PR Conventions and then fill in one of these two templates.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: