Backport "Add --dynlibdir" to 1.24
#4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christiaanb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dcoutts, @23Skidoo and @luite to be potential reviewers. |
--dynlibdir indicates the directory in which dynamic libraries are installed. By default this setting is equal to: $libdir/$abi The static libraries will still end up in: $libdir/$libsubdir With $libsubdir/$abi as the default directory for dynamic libraries, dynamic libraries will by default end up in a single shared directory (per package database). This has the potential to reduce start-up times for dynamically linked executable as only one RPATH per package database will be needed. This commit uses the functionality defined in https://phabricator.haskell.org/D2611 to tell GHC's > 8.0.1 package database that dynamic libraries are copied to the directories mentioned in the `dynamic-library-dirs` field.
christiaanb
force-pushed
the
dynlibdir-1.24
branch
from
304b71e to
5c901a6
Compare
|
@23Skidoo so actually we have to merge this first, to the 1.24 branch (and probably head too), and then ghc has to update to that before they can merge the ghc patch (D2611), since it depends on the extra field in the InstalledPackageInfo from this patch. |
|
OK, let's merge both of these and then update the version check if required. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--dynlibdir indicates the directory in which dynamic libraries
are installed. By default this setting is equal to:
$libdir/$abi
The static libraries will still end up in:
$libdir/$libsubdir
With $libsubdir/$abi as the default directory for dynamic
libraries, dynamic libraries will by default end up in a
single shared directory (per package database). This has the
potential to reduce start-up times for dynamically linked
executable as only one RPATH per package database will be
needed.
This commit uses the functionality defined in
https://phabricator.haskell.org/D2611
to tell GHC's > 8.0.1 package database that dynamic libraries
are copied to the directories mentioned in the
dynamic-library-dirsfield.