-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cabal-install to allow time 1.14 #9851
Conversation
As noted in #9848, this needs to be validated locally by reviewers because |
I think @ulysses4ever prototyped a tool to permit precisely such a usage of our own CI, but I can't find docs for it. |
They're at the bottom of CONTRIBUTING.md, I think |
Oh, great, thank you. I only searched in READMEs and the Wiki. I've updated the placeholder with the link at the bottom of https://github.com/haskell/cabal/wiki/Cabal-Packages-Hackage-Revision-Policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and Artem reports:
started CI run of the Validate workflow with time==1.14: https://github.com/haskell/cabal/actions/runs/8650585264
will see how it goes
Validate · haskell/cabal@8e971f5 - GitHub
Official upstream development repository for Cabal and cabal-install - Validate · 8e971f5
... it failed for an unfortunate reason: validate uses various ghc and some come with base older than the lower bound on base that time-1.14 has. This is clearly a shortcoming of this approach for testing version bumps :-( I'll think if there's a way around it. But in the meantime you may want to just trust the PR author that they tested it locally on one GHCV at least...
actually, the static exe job succeeded with time-1.14! https://github.com/haskell/cabal/actions/runs/8650585264/job/23719429299
@ffaf1: we have two compilation tests with the bound forced, so I think it's fine for you to approve and set the merge label without repeating the tests. |
Note that #9848 covers Cabal and Cabal-syntax already.
8b32deb
to
65842cb
Compare
I've we set the |
@mergify backport 3.12 |
✅ Backports have been created
|
Update cabal-install to allow time 1.14 (backport #9851)
Note that #9848 covers
Cabal
andCabal-syntax
already.For sanity's sake, #9848 should probably be committed first.
Template Β: This PR does not modify
cabal
behaviour (documentation, tests, refactoring, etc.)Include the following checklist in your PR: