-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render project configs as clean list in provenance message #9985
Conversation
2c8ba7e
to
369a7b7
Compare
@Mikolaj and @ffaf1 I saw the pre-release announcement for |
@ulysses4ever is the release manager for 3.12.1.0, which will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This has the potential of introducing new bugs, though, and it didn't get into the (first and last) pre-release. This is a fix for a long standing bug, not a regression, right?
This was for a situation we did not have a test for and missed at review. It is a message formatting boo-boo introduced by #9578 so its scope is limited to the display of a message. |
For 3.12.1.0 — I'd hope so. For the prerelease — I doubt it, but @Mikolaj is managing the prerelease, I think, so he's the right person to ask. |
OK, in that case, let's get this merged soon. The prerelease has been shipped already, BTW. Just announced. :) |
369a7b7
to
b0c0c77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks! Let's apply the labels soon!
@philderbeast do you want to apply the merge label? |
Label merge+no rebase is necessary when the pull request is from an organisation. |
@philderbeast: would you mind also rebasing manually so that the commit history is less non-linear? Thank you! |
- Use real-life example from Cabal project in doctest
b0c0c77
to
325ff22
Compare
Let me restart https://github.com/haskell/cabal/actions/runs/9080567805/job/25091173936?pr=9985. It may or may not be transient. |
@mergify backport 3.12 |
✅ Backports have been created
|
Fixes #9971.