Skip to content

Keyword context is not calculated correctly on values in different lines #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
VeryMilkyJoe opened this issue Aug 21, 2023 · 1 comment
Closed

Keyword context is not calculated correctly on values in different lines #3768

VeryMilkyJoe opened this issue Aug 21, 2023 · 1 comment
Assignees
@VeryMilkyJoe
Labels
component: hls-cabal-plugin Issues related to the hls-cabal-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@VeryMilkyJoe
Copy link
Collaborator

When the keyword context is calculated for a field where the value is in a different line than the keyword itself,
the context is not determined correctly as the keyword is not found.

This should be fixable by looking backwards over many lines and utilising indentation to find the correct context.

image
@VeryMilkyJoe VeryMilkyJoe added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. component: hls-cabal-plugin Issues related to the hls-cabal-plugin labels Aug 21, 2023
@VeryMilkyJoe VeryMilkyJoe self-assigned this Aug 21, 2023
@VeryMilkyJoe
Copy link
Collaborator Author

I am pretty sure, this was fixed in #4186 with the change to ParseCabalFields, so we can probably close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VeryMilkyJoe VeryMilkyJoe

Labels
component: hls-cabal-plugin Issues related to the hls-cabal-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VeryMilkyJoe