Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support structured diagnostics 2 #4433

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

Support structured diagnostics 2 #4433

wants to merge 58 commits into from

Commits on Oct 23, 2024

  1. Change FileDiagnostic type synonym to a datatype

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bd1404f View commit details
    Browse the repository at this point in the history

  2. Make ideErrorWithSource produce FileDiagnostic by adding filepath arg

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e684905 View commit details
    Browse the repository at this point in the history

  3. Supply structured error wherever we easily can - TODOs for hard parts 

    We're leaving the TODOs for either later in this PR or in another PR
    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9d4cad1 View commit details
    Browse the repository at this point in the history

  4. Fix UnitTests for new FileDiagnostic struct

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e6a0b09 View commit details
    Browse the repository at this point in the history

  5. Remove explicit uses of FileDiagnostic, add codes to LSP diagnostics

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d87c246 View commit details
    Browse the repository at this point in the history

  6. Add field for expected error codes in ghcide tests

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    cc2188c View commit details
    Browse the repository at this point in the history

  7. Expect GHC-83865 for "type error" test - basic test

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d2cbe55 View commit details
    Browse the repository at this point in the history

  8. Return structured warnings in TcModuleResult by copying from Driver

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6e1eab7 View commit details
    Browse the repository at this point in the history

  9. Store FileDiagnostic instead of LSP Diagnostic in Shake store

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    dcf9397 View commit details
    Browse the repository at this point in the history

  10. Add expected error codes for diagnostics that have them

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7bda67b View commit details
    Browse the repository at this point in the history

  11. Dispatch TODOs, amend remaining TODOs as future work

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6d1f0d7 View commit details
    Browse the repository at this point in the history

  12. Add scary comments all over copied code in Compat.Driver

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c92afae View commit details
    Browse the repository at this point in the history

  13. Update all remaining diagnostics that could use an expected error code

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b2fb63d View commit details
    Browse the repository at this point in the history

  14. Add _code to pretty printing for FileDiagnostic

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c6bc82d View commit details
    Browse the repository at this point in the history

  15. Use case instead of maybe for StructuredMessage match

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9f5391b View commit details
    Browse the repository at this point in the history

  16. Use CPP to prevent setting _code before structured errors

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    dd2229a View commit details
    Browse the repository at this point in the history

  17. Swap modifier for lenses, document StructuredMessage type

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    094974d View commit details
    Browse the repository at this point in the history

  18. Add link to Issue & MR to Compat.Driver

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e948f2a View commit details
    Browse the repository at this point in the history

  19. Drop attachReason logic from withWarnings, technically incorrect

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    79fd77e View commit details
    Browse the repository at this point in the history

  20. Revert "Drop attachReason logic", needed by pragmas-plugin 

    This reverts commit 4fed987.
    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    869edd6 View commit details
    Browse the repository at this point in the history

  21. Fix plugins where necessary for new diagnostic structure

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1b2dd28 View commit details
    Browse the repository at this point in the history

  22. Fix build issues with other tests from expectDiagnostics

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    03c8409 View commit details
    Browse the repository at this point in the history

  23. Improve comment on metadata fdStructuredMessage in FileDiagnostic

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2f83b0b View commit details
    Browse the repository at this point in the history

  24. Add note to withWarnings explaining the current state of things

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1cb1325 View commit details
    Browse the repository at this point in the history

  25. Attach reasons into data field of LSP Diagnostic instead of code field 

    Had to move `attachReason` between modules to achieve this, which is
fine because it was never exported from its own module.
    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9337f25 View commit details
    Browse the repository at this point in the history

  26. Fix up mistakes from merge, TODO fix merge issues for 9.3.0

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a857b9e View commit details
    Browse the repository at this point in the history

  27. Set CodeDescription from HaskellErrorIndex when available

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    14d6697 View commit details
    Browse the repository at this point in the history

  28. Remove debugging print, fix expectation for preprocessor tests

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    acbf1cb View commit details
    Browse the repository at this point in the history

  29. Fix CPP for using Show instance on DiagnosticCode

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    413d1b8 View commit details
    Browse the repository at this point in the history

  30. Remove diagFromErrMsgs for GHC version < 9.6.1 using CPP

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    926b6c4 View commit details
    Browse the repository at this point in the history

  31. CPP fix

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    342b9fb View commit details
    Browse the repository at this point in the history

  32. More stylish-haskell, more CPP fix

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    aaf5736 View commit details
    Browse the repository at this point in the history

  33. Fix all stylish-haskell errors triggering

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7215d80 View commit details
    Browse the repository at this point in the history

  34. Fix more CPP

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1a7856b View commit details
    Browse the repository at this point in the history

  35. Only override the LSP diagnostic code when not already set

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0a2174d View commit details
    Browse the repository at this point in the history

  36. Fixes for stylish-haskell 

    stylish-haskell does not handle CPP pragmas very well, is this a
regression?
    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    619098e View commit details
    Browse the repository at this point in the history

  37. Qualify s, t for FuzzySearch

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    361dd5b View commit details
    Browse the repository at this point in the history

  38. Ignore use of unsafePerformIO in FuzzySearch

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1ec3db3 View commit details
    Browse the repository at this point in the history

  39. Properly split GHC.Types.Error import in Diagnostics for stylish-haskell

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ef5518f View commit details
    Browse the repository at this point in the history

  40. Force type signature of annotation on FuzzySearch.dictionary

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    45e77c7 View commit details
    Browse the repository at this point in the history

  41. DRY up definition of closure_errs 

    From review haskell#4311 (comment)
    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6ca2a19 View commit details
    Browse the repository at this point in the history

  42. Remove unused imports

    @noughtmare
    noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    165e6b0 View commit details
    Browse the repository at this point in the history

  43. Post-rebase fixes

    @noughtmare
    noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1047d55 View commit details
    Browse the repository at this point in the history

  44. stylish-haskell formatting

    @noughtmare
    noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a64120f View commit details
    Browse the repository at this point in the history

  45. Fix issue with GHC 9.4

    @noughtmare
    noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1fed0f9 View commit details
    Browse the repository at this point in the history

  46. Please stylish-haskell

    @noughtmare
    noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    73bba51 View commit details
    Browse the repository at this point in the history

  47. Ignore error codes when testing GHC 9.4

    @noughtmare
    noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6c9860c View commit details
    Browse the repository at this point in the history

  48. Workaround darwin GHC bug in hls-hlint-plugin

    @noughtmare
    noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c44a43d View commit details
    Browse the repository at this point in the history

  49. Put the workaround in the right place

    @noughtmare
    noughtmare committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1f835da View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Revert "Set CodeDescription from HaskellErrorIndex when available" 

    This reverts commit 14d6697.
    @noughtmare
    noughtmare committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1bc221c View commit details
    Browse the repository at this point in the history

  2. Resolve fendor's feedback

    @noughtmare
    noughtmare committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    16551d1 View commit details
    Browse the repository at this point in the history

  3. Apply stylish-haskell formatting

    @noughtmare
    noughtmare committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5a6216b View commit details
    Browse the repository at this point in the history

  4. Apply more stylish-haskell formatting

    @noughtmare
    noughtmare committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4465f49 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge branch 'master' into support-structured-diagnostics

    @soulomoon
    soulomoon authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    79341ed View commit details
    Browse the repository at this point in the history

  2. Resolve some of soulomoon's feedback

    @noughtmare
    noughtmare committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    82367ec View commit details
    Browse the repository at this point in the history

  3. Fix small issues

    @noughtmare
    noughtmare committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ada484e View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Remove unused imports

    @noughtmare
    noughtmare committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    6c05e23 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Remove StructuredDiagnostic

    @noughtmare
    noughtmare committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    0776c65 View commit details
    Browse the repository at this point in the history