For GHC 7.6 and up, use GHC.Prim.setByteArray# #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fill byte arrays with Int8 and Word8.
|
Travis failures look spurious. |
|
There may be some bugs in the 7.6 byte array code. At least it my
sleuthing on the other byte array change is any Indiciatiin. I’ll look into
it.
Thanks for the patch. I’ll go over it after I get to the other bug
…On Fri, Dec 14, 2018 at 4:52 PM Andrew Martin ***@***.***> wrote:
Travis failures look spurious.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#222 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAQwrEku3g6KWx47NoJQkHfTjztPLYTks5u5B2tgaJpZM4ZUSYk>
.
|
|
There’s also an issue with large arrays and gc pauses that may apply to
both versions of the code. Most of the large array ops in ghc SHOULD be
changed to yield to the scheduler every once In a while
On Fri, Dec 14, 2018 at 5:28 PM Carter Schonwald <carter.schonwald@gmail.com>
wrote:
… There may be some bugs in the 7.6 byte array code. At least it my
sleuthing on the other byte array change is any Indiciatiin. I’ll look into
it.
Thanks for the patch. I’ll go over it after I get to the other bug
On Fri, Dec 14, 2018 at 4:52 PM Andrew Martin ***@***.***>
wrote:
> Travis failures look spurious.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#222 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAAQwrEku3g6KWx47NoJQkHfTjztPLYTks5u5B2tgaJpZM4ZUSYk>
> .
>
|
|
@andrewthad this and 1-2 other things would be great to apply to master after i get the 0.7 stuff green so we can include it there |
|
lets aim for this to land in a soon 0.7.1 :), though i'd like drop having the vendored qc-classes for faster builds first |
|
I've tweaked the CPP to only use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For GHC 7.6 and up, use GHC.Prim.setByteArray# instead of the FFI to fill byte arrays with Int8 and Word8. This also adds some tests to confirm that the behavior has not changed.