From 5f6e92cf3cac204c7586c0df4349db8ce63cd7dc Mon Sep 17 00:00:00 2001 From: Toan Nguyen Date: Mon, 6 Jan 2025 12:18:08 +0700 Subject: [PATCH 1/2] fix codegen log typo --- cmd/hasura-ndc-go/command/internal/schema_parser.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/hasura-ndc-go/command/internal/schema_parser.go b/cmd/hasura-ndc-go/command/internal/schema_parser.go index 9a2e018..fb58fb0 100644 --- a/cmd/hasura-ndc-go/command/internal/schema_parser.go +++ b/cmd/hasura-ndc-go/command/internal/schema_parser.go @@ -15,6 +15,7 @@ import ( "strings" "github.com/hasura/ndc-sdk-go/schema" + "github.com/hasura/ndc-sdk-go/utils" "github.com/iancoleman/strcase" "github.com/rs/zerolog/log" "golang.org/x/tools/go/packages" @@ -93,7 +94,7 @@ func parseRawConnectorSchemaFromGoCode(ctx context.Context, moduleName string, f } if len(directories) > 0 { - log.Info().Interface("directories", directories).Msgf("parsing connector schema...") + log.Info().Interface("directories", utils.GetSortedKeys(directories)).Msgf("parsing connector schema...") var packageList []*packages.Package fset := token.NewFileSet() From 88307af165c42690fc863423ba7d858471b39fcb Mon Sep 17 00:00:00 2001 From: Toan Nguyen Date: Mon, 6 Jan 2025 12:23:40 +0700 Subject: [PATCH 2/2] improve logging --- cmd/hasura-ndc-go/command/internal/schema_parser.go | 2 +- cmd/hasura-ndc-go/command/update.go | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/hasura-ndc-go/command/internal/schema_parser.go b/cmd/hasura-ndc-go/command/internal/schema_parser.go index fb58fb0..c430c0c 100644 --- a/cmd/hasura-ndc-go/command/internal/schema_parser.go +++ b/cmd/hasura-ndc-go/command/internal/schema_parser.go @@ -94,7 +94,7 @@ func parseRawConnectorSchemaFromGoCode(ctx context.Context, moduleName string, f } if len(directories) > 0 { - log.Info().Interface("directories", utils.GetSortedKeys(directories)).Msgf("parsing connector schema...") + log.Debug().Interface("directories", utils.GetSortedKeys(directories)).Msgf("parsing connector schema") var packageList []*packages.Package fset := token.NewFileSet() diff --git a/cmd/hasura-ndc-go/command/update.go b/cmd/hasura-ndc-go/command/update.go index 4e91f65..40225f0 100644 --- a/cmd/hasura-ndc-go/command/update.go +++ b/cmd/hasura-ndc-go/command/update.go @@ -16,7 +16,8 @@ func UpdateConnectorSchema(args UpdateArguments, start time.Time) { log.Info(). Str("path", args.Path). Str("connector_dir", args.ConnectorDir). - Msg("generating connector schema...") + Interface("directories", args.Directories). + Msg("generating connector schema") moduleName, err := getModuleName(args.Path) if err != nil {