Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudinary setup #53

Closed
wants to merge 5 commits into from
Closed

Cloudinary setup #53

wants to merge 5 commits into from

Conversation

Gamey001
Copy link
Collaborator

@Gamey001 Gamey001 commented Oct 8, 2021

What this PR does (required):

  • Allows for profile picture upload

Screenshots / Videos (front-end only):

  • Post at least one screenshot to show the feature in action. Only required in front-end work

Any information needed to test this feature (required):

-you need the Cloundinary team accounts details and set them in your .env

Any issues with the current functionality (optional):

  • none

Copy link
Contributor

@moffatethan moffatethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR is all contained in #51, do we want to just close this one and work off #51 which has been more reviewed?

Comment on lines 5 to 9
// @route POST /profile/create
// @desc Create new profile
// @access Public
exports.createProfile = asyncHandler(async (req, res, next) => {
try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this code in #51, let's get this fixed please 😄

@Gamey001 Gamey001 linked an issue Oct 10, 2021 that may be closed by this pull request
@Gamey001 Gamey001 closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup: Cloudinary
2 participants