Add DWC2 deinit support #3378
Open
Add DWC2 deinit support #3378
+1,260
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HiFiPhile <admin@hifiphile.com>
Signed-off-by: HiFiPhile <admin@hifiphile.com>
Signed-off-by: HiFiPhile <admin@hifiphile.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds deinitialization support for the Synopsys DWC2 USB controller, enabling dynamic start/stop of USB host and device modes. The implementation mirrors the initialization sequence in reverse, disabling interrupts, disconnecting from the bus, and resetting the core. This was tested on STM32H7S3 with device mode toggling via button press.
Key Changes
- Implements
hcd_deinit()anddcd_deinit()functions for DWC2 host and device controllers - Adds common
dwc2_core_deinit()function shared between host and device modes - Updates error handling in
tuh_deinit()andtud_deinit()to useTU_ASSERTconsistently - Fixes button active state configuration for STM32H7S3 Nucleo board
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/portable/synopsys/dwc2/hcd_dwc2.c |
Adds host controller deinit implementation with interrupt disable |
src/portable/synopsys/dwc2/dwc2_common.h |
Declares dwc2_core_deinit() for shared deinitialization logic |
src/portable/synopsys/dwc2/dwc2_common.c |
Implements common core deinit with soft disconnect and core reset |
src/portable/synopsys/dwc2/dcd_dwc2.c |
Adds device controller deinit with disconnect and cleanup |
src/host/usbh.c |
Changes hcd_deinit() call to use TU_ASSERT for error checking |
src/device/usbd.c |
Changes dcd_deinit() call to use TU_ASSERT for consistency |
hw/bsp/stm32h7rs/boards/stm32h7s3nucleo/board.h |
Corrects button active state from 1 to 0 (active-low with pullup) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: HiFiPhile <admin@hifiphile.com>
Signed-off-by: HiFiPhile <admin@hifiphile.com>
Signed-off-by: HiFiPhile <admin@hifiphile.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
HiFiPhile
force-pushed
the
dwc2_deinit
branch
from
2c8f34d to
2a994a3
Compare
Signed-off-by: HiFiPhile <admin@hifiphile.com>
HiFiPhile
force-pushed
the
dwc2_deinit
branch
from
2a994a3 to
9461753
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roma-jam Hi, I've added deinit support to dwc2.
A dynamic switch example is added and works on
ESP32-S3-DevKitC,NUCLEO-H7S3L8,Nucleo-U5A5ZJ-QandSTM32F407-DISCO.