Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWSConfig getConnectionTimeoutSeconds is not used during connection #22

Closed
ihsandemir opened this issue Apr 12, 2017 · 1 comment
Closed

AWSConfig getConnectionTimeoutSeconds is not used during connection #22

ihsandemir opened this issue Apr 12, 2017 · 1 comment
Labels
Type: Defect
Milestone
2.1

Comments

@ihsandemir
Copy link
Contributor

It seems like DescribeInstances did not use any timeout during https url connection https://github.com/hazelcast/hazelcast-aws/blob/master/src/main/java/com/hazelcast/aws/impl/DescribeInstances.java#L259 . There is a config parameter set/getConnectionTimeoutSeconds which I expect to be used.

Furthermore, this timeout probably needs to be used for other http requests such as https://github.com/hazelcast/hazelcast-aws/blob/master/src/main/java/com/hazelcast/aws/impl/DescribeInstances.java#L132
emrahkocaman pushed a commit that referenced this issue Jun 29, 2017
@emrahkocaman
fixes for hazelcast-aws Github issues #29 and #22 (#30)
b04f49f 
* fixes for hazelcast-aws Github issues #29 and #22

* fixes for checkstyle errors

* fixes for checkstyle errors

* extended strategy factory tests

* removed Configuration to AwsConfig

* Configuration fixes, we now allow w/out any creds, or iam-role defined in config file.

* missing default value for timeout added
@mesutcelik
Copy link
Contributor

fixed by #30

@mesutcelik mesutcelik added this to the 2.0.2 milestone Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Defect
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@mesutcelik @ihsandemir