[API-875] Deserialize SqlRows lazily
#472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
- Coverage 95.15% 94.87% -0.29%
==========================================
Files 345 345
Lines 17696 17700 +4
==========================================
- Hits 16838 16792 -46
- Misses 858 908 +50
Continue to review full report at Codecov.
|
zpqrtbnk
approved these changes
Sep 16, 2021
This is a required change to be able to use parts of the row,
even if we cannot deserialize some column values.
Also, lazy deserialization is a plus on its own.
To accomplish this, similar to the Java client, I have changed the
code so that, we try to deserialize column values when we
call `get_object` or `get_object_with_index`. Note that,
just like the Java client
```
row.get_object("smth")
row.get_object("smth")
```
will result in two deserializations.
We could easily solve this with an extra object per row (something
like LazyDeserializable class with two fields: serialized and deserialized
where once we deserialize it, it assigns the result to deserialized and
return it for the subsequent calls). But, I didn't want to go that way due
to extra object cost.
mdumandag
force-pushed
the
lazy-obj-deserialization
branch
from
f84c96a
to
7b39199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a required change to be able to use parts of the row,
even if we cannot deserialize some column values.
Also, lazy deserialization is a plus on its own.
To accomplish this, similar to the Java client, I have changed the
code so that, we try to deserialize column values when we
call
get_objectorget_object_with_index. Note that,just like the Java client
will result in two deserializations.
We could easily solve this with an extra object per row (something
like LazyDeserializable class with two fields: serialized and deserialized
where once we deserialize it, it assigns the result to deserialized and
return it for the subsequent calls). But, I didn't want to go that way due
to extra object cost.
Closes #447