Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kickoff 5.2.0 development [API-1564] #609

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

mdumandag
Copy link
Contributor

This PR contains various fixes to make the client compatible with the 5.2 server.

  • Server version used in tests bumped to 5.2.2
  • For Compact, field kinds are updated with the up-to-date enum values and they are moved to the serialization.api from compact, to match with the Java side
  • Dependency on the enterprise-tests JAR is removed and the self-signed certificates that we depend on moved to the client-side, instead of adding a dependency to the private test artifacts.
  • Some reactor related tests that fail on macOS are fixed

This PR contains various fixes to make the client compatible with
the 5.2 server.

- Server version used in tests bumped to 5.2.2
- For Compact, field kinds are updated with the up-to-date enum values
and they are moved to the serialization.api from compact, to match
with the Java side
- Dependency on the enterprise-tests JAR is removed and the self-signed
certificates that we depend on moved to the client-side, instead
of adding a dependency to the private test artifacts.
- Some reactor related tests that fail on macOS are fixed
@mdumandag mdumandag requested a review from yuce March 6, 2023 12:11
Copy link
Contributor

@yuce yuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two nits.

hazelcast/serialization/api.py Show resolved Hide resolved
tests/unit/reactor_test.py Show resolved Hide resolved
yuce
yuce previously approved these changes Mar 7, 2023
@yuce yuce self-requested a review March 7, 2023 08:01
@codecov-commenter
Copy link

Codecov Report

Merging #609 (4e751d1) into master (1348e39) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         357      357           
  Lines       20510    20513    +3     
=======================================
+ Hits        19787    19790    +3     
  Misses        723      723           
Impacted Files Coverage Δ
hazelcast/serialization/compact.py 99.02% <ø> (-0.04%) ⬇️
hazelcast/serialization/api.py 100.00% <100.00%> (ø)
hazelcast/statistics.py 87.64% <0.00%> (-0.57%) ⬇️
hazelcast/connection.py 92.19% <0.00%> (-0.17%) ⬇️
hazelcast/listener.py 92.93% <0.00%> (+1.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mdumandag
Copy link
Contributor Author

@yuce can you re-approve, please?

@mdumandag mdumandag merged commit 244084b into hazelcast:master Mar 7, 2023
@mdumandag mdumandag deleted the 5.2-kickoff branch March 7, 2023 09:14
@mdumandag mdumandag added this to the 5.2.0 milestone Mar 7, 2023
@mdumandag mdumandag self-assigned this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants