Prevent triggering builds on closed PRs [DI-248]

[JackPGreen]

Skips all kind of event triggers for closed PRs, rather than just for comments as per jenkinsci/ghprb-plugin#54.

I've not added a test to cover this, as there's no existing test coverage for pull_request events in org.jenkinsci.plugins.ghprb.GhprbRootActionTest, nor is there any example payloads in org.jenkinsci.plugins.ghprb.GhprbTestUtil.

Fixes: jenkinsci/ghprb-plugin#865, DI-248

Post-merge actions:

• Deploy in Jenkins
• Test
• Raise upstream PR

[nishaatr]

General questions

Deploy in Jenkins

How? just want to know

Test

So the change has not been tested?

Raise upstream PR

do we push changes to upstream always?

[JackPGreen]

General questions

Deploy in Jenkins

How? just want to know

Process is outlined in the README

Test

So the change has not been tested?

No, there's no way I can test it locally.
(well, not easily at least).

Raise upstream PR

do we push changes to upstream always?

Don't know, but seems the right thing to do.

[nishaatr]

Don't know, but seems the right thing to do.

yes would be but this doesn't look like a fork

[JackPGreen]

Don't know, but seems the right thing to do.

yes would be but this doesn't look like a fork

It's not a fork, but we can still do it.

[nishaatr]

Don't know, but seems the right thing to do.

yes would be but this doesn't look like a fork

It's not a fork, but we can still do it.

yes true. but looks like we never pushed upstream changes and reading Slack comments, might not be worth the effort.
Also last master commit in orig repo was ~2yrs ago and there are a few open PRs.
No strong opinion but if we don't do upstream push then best to update PR description

[kwart]

LGTM

[JackPGreen]

@kwart thanks, are you able to merge, please?

Only those with write access to this repository can merge pull requests.