From 9ce28570bf3da9571198d44d693c7ad7038cde33 Mon Sep 17 00:00:00 2001
From: Oskar Zabik <oskar.zabik@gmail.com>
Date: Tue, 12 Nov 2024 10:35:26 +0000
Subject: [PATCH] fix: default to files:read scope for Figma provider (#1831)

Closes #1827 by defaulting to `files:read` oAuth scope for Figma as per
the issue.
---
 internal/api/external_figma_test.go | 2 +-
 internal/api/provider/figma.go      | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/internal/api/external_figma_test.go b/internal/api/external_figma_test.go
index ccd59b1ff..6e119b9ec 100644
--- a/internal/api/external_figma_test.go
+++ b/internal/api/external_figma_test.go
@@ -27,7 +27,7 @@ func (ts *ExternalTestSuite) TestSignupExternalFigma() {
 	ts.Equal(ts.Config.External.Figma.RedirectURI, q.Get("redirect_uri"))
 	ts.Equal(ts.Config.External.Figma.ClientID, []string{q.Get("client_id")})
 	ts.Equal("code", q.Get("response_type"))
-	ts.Equal("file_read", q.Get("scope"))
+	ts.Equal("files:read", q.Get("scope"))
 
 	claims := ExternalProviderClaims{}
 	p := jwt.NewParser(jwt.WithValidMethods([]string{jwt.SigningMethodHS256.Name}))
diff --git a/internal/api/provider/figma.go b/internal/api/provider/figma.go
index 2ebdd0131..ba812da78 100644
--- a/internal/api/provider/figma.go
+++ b/internal/api/provider/figma.go
@@ -37,9 +37,8 @@ func NewFigmaProvider(ext conf.OAuthProviderConfiguration, scopes string) (OAuth
 	authHost := chooseHost(ext.URL, defaultFigmaAuthBase)
 	apiHost := chooseHost(ext.URL, defaultFigmaAPIBase)
 
-	// Figma only provides the "file_read" scope.
 	oauthScopes := []string{
-		"file_read",
+		"files:read",
 	}
 
 	if scopes != "" {