Skip to content
This repository has been archived by the owner on Jun 23, 2020. It is now read-only.

Add persons and corporate bodies without GND ID to "contributor"/"creator" array #17

Closed
acka47 opened this issue Dec 17, 2015 · 14 comments · Fixed by hbz/lobid-resources#102
Assignees

Comments

@acka47
Copy link
Contributor

acka47 commented Dec 17, 2015

Will add details and an example as soon as @dr0i has pointed me to a test file that has creator and/or contributors with and without GND ID.

@acka47 acka47 assigned acka47 and dr0i and unassigned acka47 Dec 17, 2015
@dr0i
Copy link
Member

dr0i commented Dec 17, 2015

Couldn't find the specification of lv:contributorOrder. Want to know:
should there only be contributors or also creators?

@acka47
Copy link
Contributor Author

acka47 commented Dec 17, 2015

It should cover creator, contributor as well as all MARC relators.

@acka47
Copy link
Contributor Author

acka47 commented Jan 22, 2016

We must use the same generic property for the label as we do for the other subject, currently this is gnd:preferredName. Example:

{
   "@context":"http://lobid.org/download/contextTmp.json",
   "@id":"http://lobid.org/resources/HT018700720#!",
   "contributor":[
      {
         "@id":"http://d-nb.info/gnd/2006655-7",
         "preferredName":"Bundeszentrale für Gesundheitliche Aufklärung",
         "preferredNameForTheCorporateBody":"Bundeszentrale für Gesundheitliche Aufklärung"
      },
      {
         "@id":"http://d-nb.info/gnd/136371671",
         "preferredName":"Amrhein, Ludwig",
         "preferredNameForThePerson":"Amrhein, Ludwig"
      },
      {
         "@id":"http://d-nb.info/gnd/129961604",
         "preferredName":"Heusinger, Josefine",
         "preferredNameForThePerson":"Heusinger, Josefine"
      },
      {
         "@id":"http://d-nb.info/gnd/115325859",
         "preferredName":"Wolter, Birgit",
         "preferredNameForThePerson":"Wolter, Birgit"
      },
      {
         "preferredNameForThePerson": "Ottovay, Kathrin"
      }
   ],
   "contributorOrder":[
      "http://d-nb.info/gnd/136371671 | http://d-nb.info/gnd/129961604 | Ottovay, Kathrin | http://d-nb.info/gnd/115325859 | http://d-nb.info/gnd/2006655-7"
   ]

@acka47 acka47 changed the title Add alternate labels and persons without GND ID to "contributor"/"creator" array Add persons without GND ID to "contributor"/"creator" array Jan 22, 2016
@acka47
Copy link
Contributor Author

acka47 commented Jan 22, 2016

I renamed this issue and made a separate one for the alternate labels/variant names, see #24.

@acka47
Copy link
Contributor Author

acka47 commented Jan 22, 2016

We should consider typing these entries as http://d-nb.info/standards/elementset/gnd#UndifferentiatedPerson. For the example this would look like:

{
   "@context":"http://lobid.org/download/contextTmp.json",
   "@id":"http://lobid.org/resources/HT018700720#!",
   "contributor":[
      {
         "preferredNameForThePerson": "Ottovay, Kathrin",
         "@type": "http://d-nb.info/standards/elementset/gnd#UndifferentiatedPerson"
      }
   ]
}

@acka47
Copy link
Contributor Author

acka47 commented Jan 26, 2016

Re. my last comment. We will use gnd:Person. For the example this results in:

{
   "@context":"http://lobid.org/download/contextTmp.json",
   "@id":"http://lobid.org/resources/HT018700720#!",
   "contributor":[
      {
         "preferredNameForThePerson": "Ottovay, Kathrin",
         "@type": "http://d-nb.info/standards/elementset/gnd#Person"
      }
   ]
}

With #26 it will just read Person.

@acka47
Copy link
Contributor Author

acka47 commented Apr 22, 2016

Same for corporate bodies. As hbz/lobid#302 deals with a similar but different problem I am broadening the scope of this issue and adjust the title.

@acka47 acka47 changed the title Add persons without GND ID to "contributor"/"creator" array Add persons and corporate bodies without GND ID to "contributor"/"creator" array Apr 22, 2016
@dr0i dr0i added working and removed ready labels Aug 31, 2016
@dr0i
Copy link
Member

dr0i commented Aug 31, 2016

For structural equivalence see also #23.

@dr0i
Copy link
Member

dr0i commented Aug 31, 2016

@acka47 Should the contributors with an id not also typed as gnd:Person? Or should we leave this out for objects with id's?

@dr0i
Copy link
Member

dr0i commented Aug 31, 2016

@acka47 also, what's with a type for contributor as coorporate bodies? Wouldn't this be quite analogous to the forementioned issue with persons? I have in mind to use http://d-nb.info/standards/elementset/gnd#CorporateBody.

@acka47
Copy link
Contributor Author

acka47 commented Aug 31, 2016

Should the contributors with an id not also typed as gnd:Person? Or should we leave this out for objects with id's?

For typing of GND entitites I made a separate issue, see #25 .

what's with a type for contributor as coorporate bodies?

Please use http://d-nb.info/standards/elementset/gnd#CorporateBody.

@dr0i
Copy link
Member

dr0i commented Aug 31, 2016

Ok.
Deployed to staging, see e.g. http://staging.lobid.org/resources/HT018700720.
With the data now under dct:contributor, maybe we can get rid of contributorName?

@dr0i dr0i removed their assignment Aug 31, 2016
@dr0i dr0i added review and removed working labels Aug 31, 2016
@acka47
Copy link
Contributor Author

acka47 commented Aug 31, 2016

With the data now under dct:contributor, maybe we can get rid of contributorName?

Definitely. I suggest removing deprecated properties after implementing all changes in API 2.0, see hbz/lobid-resources#8.

@acka47
Copy link
Contributor Author

acka47 commented Sep 1, 2016

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants