From 5c203759bcc4b7b4d64fb20d49039fe207b77fa1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tobias=20B=C3=BClte?= Date: Mon, 25 Sep 2023 11:28:51 +0200 Subject: [PATCH] Delete isil redirect lookup This is not needed anymore due to the lookup to the current lobidOrganisationsMapping.tsv --- .../org/lobid/resources/run/AlmaMarcXmlFix2lobidJsonEs.java | 1 - src/main/resources/alma/fix/item.fix | 2 -- src/main/resources/alma/fix/maps.fix | 1 - .../lobid/resources/AlmaMarc21XmlToLobidJsonMetafixTest.java | 1 - 4 files changed, 5 deletions(-) diff --git a/src/main/java/org/lobid/resources/run/AlmaMarcXmlFix2lobidJsonEs.java b/src/main/java/org/lobid/resources/run/AlmaMarcXmlFix2lobidJsonEs.java index 69c8f129a..6dc66c4ed 100644 --- a/src/main/java/org/lobid/resources/run/AlmaMarcXmlFix2lobidJsonEs.java +++ b/src/main/java/org/lobid/resources/run/AlmaMarcXmlFix2lobidJsonEs.java @@ -129,7 +129,6 @@ public void run() { fixVariables.put("almaMmsId2rpbId", "./maps/almaMmsId2rpbId.tsv"); fixVariables.put("lobidOrganisationsMapping.tsv", "./maps/lobidOrganisationsMapping.tsv"); fixVariables.put("hbzowner2sigel.tsv", "./maps/hbzowner2sigel.tsv"); - fixVariables.put("isilRedirect.tsv", "./maps/isilRedirect.tsv"); fixVariables.put("rpb2.ttl", "./maps/rpb2.ttl"); fixVariables.put("rpb-spatial.ttl", "./maps/rpb-spatial.ttl"); fixVariables.put("rpb.ttl", "./maps/rpb.ttl"); diff --git a/src/main/resources/alma/fix/item.fix b/src/main/resources/alma/fix/item.fix index ee1a6f4e8..ae2e6fc94 100644 --- a/src/main/resources/alma/fix/item.fix +++ b/src/main/resources/alma/fix/item.fix @@ -21,7 +21,6 @@ do list(path:"ITM ", "var": "$i") copy_field("$i.w","$i.@sublibraryIsil") lookup("$i.@sublibraryIsil", "hbzowner2sigel",delete:"true") lookup("$i.@sublibraryIsil", "sigel2isilMap",delete:"true") - lookup("$i.@sublibraryIsil", "isilRedirect") # following fix checks for sublibrary codes and if they map to provided sublocation Isil unless exists("$i.@sublibraryIsil") paste("$i.@sublibraryIsil","$i.M","~+","$i.w",join_char:"") @@ -62,7 +61,6 @@ do list(path: "HOL ", "var": "$i") copy_field("$H52.b","$i.@sublibraryIsil") lookup("$i.@sublibraryIsil", "hbzowner2sigel",delete:"true") lookup("$i.@sublibraryIsil", "sigel2isilMap",delete:"true") - lookup("$i.@sublibraryIsil", "isilRedirect") # following fix checks for sublibrary codes and if they map to provided sublocation Isil unless exists("$i.@sublibraryIsil") paste("$i.@sublibraryIsil","$i.M","~+","$H52.b",join_char:"") diff --git a/src/main/resources/alma/fix/maps.fix b/src/main/resources/alma/fix/maps.fix index 498aabd5a..21aa9eb9c 100644 --- a/src/main/resources/alma/fix/maps.fix +++ b/src/main/resources/alma/fix/maps.fix @@ -9,7 +9,6 @@ put_filemap("$[lobidOrganisationsMapping.tsv]","lobidOrgLabels", sep_char:"\t",k put_filemap("$[lobidOrganisationsMapping.tsv]","sigel2isilMap", sep_char:"\t",key_column:"2",value_column:"1",expected_columns:"-1") put_filemap("$[hbzowner2sigel.tsv]","hbzowner2sigel", sep_char:"\t",key_column:"0",value_column:"2",expected_columns:"-1") -put_filemap("$[isilRedirect.tsv]","isilRedirect", sep_char:"\t",key_column:"1",value_column:"0",expected_columns:"-1") put_filemap("$[picaCreatorId2Isil.tsv]","picaCreatorId2Isil", sep_char:"\t", sep_char:"\t",key_column:"0",value_column:"2",expected_columns:"-1") diff --git a/src/test/java/org/lobid/resources/AlmaMarc21XmlToLobidJsonMetafixTest.java b/src/test/java/org/lobid/resources/AlmaMarc21XmlToLobidJsonMetafixTest.java index 99379889b..652cee43d 100644 --- a/src/test/java/org/lobid/resources/AlmaMarc21XmlToLobidJsonMetafixTest.java +++ b/src/test/java/org/lobid/resources/AlmaMarc21XmlToLobidJsonMetafixTest.java @@ -73,7 +73,6 @@ public void setup() { fixVariables.put("almaMmsId2rpbId", "src/main/resources/alma/maps/almaMmsId2rpbId.tsv"); fixVariables.put("lobidOrganisationsMapping.tsv", "src/main/resources/alma/maps/lobidOrganisationsMapping.tsv"); fixVariables.put("hbzowner2sigel.tsv", "src/main/resources/alma/maps/hbzowner2sigel.tsv"); - fixVariables.put("isilRedirect.tsv", "src/main/resources/alma/maps/isilRedirect.tsv"); fixVariables.put("rpb2.ttl", "src/main/resources/alma/maps/rpb2.ttl"); fixVariables.put("rpb-spatial.ttl", "src/main/resources/alma/maps/rpb-spatial.ttl"); fixVariables.put("rpb.ttl", "src/main/resources/alma/maps/rpb.ttl");