Board: Initial checklist support #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
# Conflicts: # models/board/src/index.ts # plugins/board-resources/src/components/popups/Menu.svelte # plugins/board/src/index.ts
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Closed
Signed-off-by: Anna No <anna.no@xored.com>
…-support # Conflicts: # plugins/board-resources/src/index.ts # plugins/view-resources/src/index.ts
haiodo
requested changes
May 6, 2022
| @@ -21,7 +21,7 @@ | |||
| import IconClose from './icons/Close.svelte' | |||
| import plugin from '../plugin' | |||
|
|
|||
| export let icon: Asset | AnySvelteComponent | |||
There was a problem hiding this comment.
What the difference with EditBox if icon become optional?
|
|
||
| async function fetchChecklists () { | ||
| if (object) { | ||
| checklists = await client.findAll(task.class.TodoItem, { space: object.space, attachedTo: object._id }) |
| let hovered: Ref<TodoItem> | undefined | ||
|
|
||
| async function fetch () { | ||
| checklistItems = await client.findAll(task.class.TodoItem, { space: value.space, attachedTo: value._id }) |
| return | ||
| } | ||
| await client.addCollection(task.class.TodoItem, value.space, value._id, value._class, 'items', item) | ||
| fetch() |
There was a problem hiding this comment.
No need to fetch if live query is used
| } | ||
|
|
||
| client | ||
| .findAll(board.class.Card, { todoItems: { $gt: 0 } }, { lookup: { _id: { todoItems: task.class.TodoItem } } }) |
There was a problem hiding this comment.
Please use asynchronous/await function
There was a problem hiding this comment.
Updated to liveQuery
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
haiodo
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.