diff --git a/Clocks.Net/Clocks.Abstraction/ILogicalClock.cs b/Clocks.Net/Clocks.Abstraction/ILogicalClock.cs index fdce7f29..3982dcb0 100644 --- a/Clocks.Net/Clocks.Abstraction/ILogicalClock.cs +++ b/Clocks.Net/Clocks.Abstraction/ILogicalClock.cs @@ -8,10 +8,10 @@ namespace Clocks { /// - /// Basic interface for a logical clock - /// Typical logical clocks are lamport scalar clock & vector clock + /// Basic interface for a logical clock. + /// Typical logical clocks are lamport scalar clock &. vector clock /// - /// The concrete type of time point + /// The concrete type of time point. public interface ILogicalClock : IClock where T : IComparable, IEquatable { @@ -23,7 +23,7 @@ public interface ILogicalClock : IClock /// /// Increments the internal clock and get the timepoint. /// - /// The incremented clock timepoint + /// The incremented clock timepoint. T IncrementAndGet(); /// diff --git a/Clocks.Net/Clocks.Abstraction/IPhysicalClock.cs b/Clocks.Net/Clocks.Abstraction/IPhysicalClock.cs index 5d0657ef..a6f68ee1 100644 --- a/Clocks.Net/Clocks.Abstraction/IPhysicalClock.cs +++ b/Clocks.Net/Clocks.Abstraction/IPhysicalClock.cs @@ -8,10 +8,10 @@ namespace Clocks { /// - /// Basic interface for a physical clock - /// Physical clock could be regarded as a logical clock + /// Basic interface for a physical clock. + /// Physical clock could be regarded as a logical clock. /// - /// The concrete type of time point + /// The concrete type of time point. /// public interface IPhysicalClock : IClock where T : IComparable, IEquatable diff --git a/Clocks.Net/Clocks.Abstraction/IStopwatchProvider.cs b/Clocks.Net/Clocks.Abstraction/IStopwatchProvider.cs index bf8252f7..d2525887 100644 --- a/Clocks.Net/Clocks.Abstraction/IStopwatchProvider.cs +++ b/Clocks.Net/Clocks.Abstraction/IStopwatchProvider.cs @@ -8,7 +8,7 @@ namespace Clocks { /// - /// The factory providing + /// The factory providing. /// public interface IStopwatchProvider { @@ -46,12 +46,12 @@ public interface IStopwatchProvider : IStopwatchProvider T GetTimestamp(); /// - /// Parses the duration from to to a readable . + /// Parses the duration from to to a readable . /// - /// The starting timestamp. - /// The ending timestamp. - /// The readable representing the duration from to . - TimeSpan ParseDuration(T from, T to); + /// The starting timestamp. + /// The ending timestamp. + /// The readable representing the duration from to . + TimeSpan ParseDuration(T fromTimestamp, T toTimestamp); /// /// Gets the next timestamp elapsed from . diff --git a/Clocks.Net/Clocks.System/SystemStopwatchProvider.cs b/Clocks.Net/Clocks.System/SystemStopwatchProvider.cs index 2daa8a40..cd546026 100644 --- a/Clocks.Net/Clocks.System/SystemStopwatchProvider.cs +++ b/Clocks.Net/Clocks.System/SystemStopwatchProvider.cs @@ -31,9 +31,9 @@ public long GetTimestamp() return Stopwatch.GetTimestamp(); } - public TimeSpan ParseDuration(long from, long to) + public TimeSpan ParseDuration(long fromTimestamp, long toTimestamp) { - return TimeSpan.FromSeconds((to - from) / (double)Stopwatch.Frequency); + return TimeSpan.FromSeconds((toTimestamp - fromTimestamp) / (double)Stopwatch.Frequency); } public IStopwatch StartNew() diff --git a/Clocks.Net/Directory.Build.props b/Clocks.Net/Directory.Build.props index fb2c016f..59276d4e 100644 --- a/Clocks.Net/Directory.Build.props +++ b/Clocks.Net/Directory.Build.props @@ -8,6 +8,9 @@ README.md $([System.IO.File]::ReadAllText("$(EnlistmentRoot)/Clocks.Net/ReleaseNotes.md")) + + Recommended + NU1507 diff --git a/Clocks.Net/ReleaseNotes.md b/Clocks.Net/ReleaseNotes.md index a6114299..58083524 100644 --- a/Clocks.Net/ReleaseNotes.md +++ b/Clocks.Net/ReleaseNotes.md @@ -2,8 +2,7 @@ ## v1.4.1 -No source code changes. - 1. Support reproducible build. 2. Generate symbol package. 3. Include README.md into package. +4. Fix all Recommended level code analysis warnings.