Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release.md #107

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Update release.md #107

merged 2 commits into from
Aug 19, 2023

Conversation

mavaylon1
Copy link
Contributor

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
Update the release script to remove HDMF instances for HDMF-Zarr.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

No tests

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.38% ⚠️

Comparison is base (d47fc82) 82.30% compared to head (6181d5a) 81.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #107      +/-   ##
==========================================
- Coverage   82.30%   81.92%   -0.38%     
==========================================
  Files          11       11              
  Lines        2667     2667              
==========================================
- Hits         2195     2185      -10     
- Misses        472      482      +10     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 marked this pull request as ready for review August 19, 2023 03:42
@mavaylon1 mavaylon1 merged commit 086c9bc into dev Aug 19, 2023
20 checks passed
@mavaylon1 mavaylon1 deleted the release_script branch August 19, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants