cmake: Fix "tidy" CI job #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not reference the `HOST` variable before defining it.
Fix `contrib/devtools/iwyu/bitcoin.core.imp` file location.
|
See the recent push to bitcoin#29790 for the CI logs. |
theuni
reviewed
May 22, 2024
| @@ -61,8 +61,6 @@ export CCACHE_COMPRESS=${CCACHE_COMPRESS:-1} | |||
| export CCACHE_DIR=${CCACHE_DIR:-$BASE_SCRATCH_DIR/.ccache} | |||
| # Folder where the build result is put (bin and lib). | |||
| export BASE_OUTDIR=${BASE_OUTDIR:-$BASE_SCRATCH_DIR/out} | |||
| # Folder where the build is done (dist and out-of-tree build). | |||
| export BASE_BUILD_DIR=${BASE_BUILD_DIR:-$BASE_SCRATCH_DIR/build-$HOST} | |||
There was a problem hiding this comment.
HOST should be set (for cross) when importing the CI config in this line:
echo "Setting specific values in env"
So an alternative would be (in this context) to fall back to build-native, if the HOST isn't set.
But this is fine, too.
|
Friendly ping @maflcko :) |
maflcko
approved these changes
May 23, 2024
| @@ -61,8 +61,6 @@ export CCACHE_COMPRESS=${CCACHE_COMPRESS:-1} | |||
| export CCACHE_DIR=${CCACHE_DIR:-$BASE_SCRATCH_DIR/.ccache} | |||
| # Folder where the build result is put (bin and lib). | |||
| export BASE_OUTDIR=${BASE_OUTDIR:-$BASE_SCRATCH_DIR/out} | |||
| # Folder where the build is done (dist and out-of-tree build). | |||
| export BASE_BUILD_DIR=${BASE_BUILD_DIR:-$BASE_SCRATCH_DIR/build-$HOST} | |||
There was a problem hiding this comment.
HOST should be set (for cross) when importing the CI config in this line:
echo "Setting specific values in env"
So an alternative would be (in this context) to fall back to build-native, if the HOST isn't set.
But this is fine, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first point from bitcoin#29790 (comment):