-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Fix hardening flags #211
Conversation
A few things:
|
Do not pass `-mbranch-protection=bti` during link stage.
$<$<NOT:$<CONFIG:Debug>>:-U_FORTIFY_SOURCE> | ||
$<$<NOT:$<CONFIG:Debug>>:-D_FORTIFY_SOURCE=3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dealing with an individual options within generator expressions is much easier.
I left only this change, which effectively is pulled from the current #93.
I'll submit a demo branch shortly. |
ACK e2f2f23 Tested with and without PR and can now see the hardening flag not being passed during linking on M1 Mac. |
During testing #93, a few issues were noticed:
The other change simplifies the summary code in #93.