From c1c3a5fec2b0da79ec96e681bcf71a399d45e44d Mon Sep 17 00:00:00 2001 From: Arjav Desai Date: Mon, 9 Nov 2020 09:21:54 -0600 Subject: [PATCH 1/3] helidon/2486 - Fix broken links --- DEV-GUIDELINES.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DEV-GUIDELINES.md b/DEV-GUIDELINES.md index 334b8d49259..67e5c08cdbd 100644 --- a/DEV-GUIDELINES.md +++ b/DEV-GUIDELINES.md @@ -71,7 +71,7 @@ reviewing changes done by others. configured (e.g. a component may expect tracing endpoint - if not defined, tracing may be disabled) -Example: [io.helidon.security.providers.oidc.common.OidcConfig](security/providers/oidc-common/src/main/java/io/helidon/security/oidc/common/OidcConfig.java) +Example: [io.helidon.security.providers.oidc.common.OidcConfig](security/providers/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcConfig.java) # Getters and Setters 1. We do not use the verb, e.g. when a property "port" exists, the following methods are used: @@ -81,7 +81,7 @@ Example: [io.helidon.security.providers.oidc.common.OidcConfig](security/provide 1. Default is without a verb (e.g. authenticate(boolean atn), boolean authenticate()) 2. If this would be ambiguous, we can use verb to clear the meaning (e.g. isAuthenticated() or shouldAuthenticate()) -Example: [io.helidon.security.providers.oidc.common.OidcConfig](security/providers/oidc-common/src/main/java/io/helidon/security/oidc/common/OidcConfig.java) +Example: [io.helidon.security.providers.oidc.common.OidcConfig](security/providers/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcConfig.java) # Fluent API 1. We use fluent API where applicable From ed3b67c479c081f14b7dc8a0b9818756cc07825d Mon Sep 17 00:00:00 2001 From: Arjav Desai Date: Mon, 9 Nov 2020 10:33:31 -0600 Subject: [PATCH 2/3] Add Dev-guidelines as reference --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ab4e049844e..7f7848e50e5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -30,7 +30,7 @@ The process: 0. Sign the [OCA](https://www.oracle.com/technetwork/community/oca-486395.html) 1. Fork the repo 2. Fix an issue or create an issue and fix it -3. Create a Pull Request that fixes the issue +3. Create a Pull Request that fixes the issue. Follow [DEV-GUIDELINES](DEV-GUIDELINES.md) for a list of rules and best practices followed by project Helidon. 4. Watch your PR for pipeline results. If there are failures then fix them. 5. We will review your PR and merge as appropriate. From c2f5225fd24c51180a4d9889a2a2f8132fe6fc73 Mon Sep 17 00:00:00 2001 From: Arjav Desai Date: Fri, 4 Dec 2020 12:05:37 -0600 Subject: [PATCH 3/3] fix link and typo --- docs/common/guides/graalnative.adoc | 2 +- docs/common/guides/jlink_image.adoc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/common/guides/graalnative.adoc b/docs/common/guides/graalnative.adoc index f038b85dc79..8c5e92c3500 100644 --- a/docs/common/guides/graalnative.adoc +++ b/docs/common/guides/graalnative.adoc @@ -35,7 +35,7 @@ In this guide you will learn how to build a native image locally on your machine == Install GraalVM and the Native Image Command -After https://github.com/oracle/graal/releases[downloading and installing] GraalVM, +After https://github.com/graalvm/graalvm-ce-builds/releases[downloading and installing] GraalVM, set the `GRAALVM_HOME` environment variable to point at your GraalVM installation. [source,bash] diff --git a/docs/common/guides/jlink_image.adoc b/docs/common/guides/jlink_image.adoc index 1c112ab3a1a..b2a7fbca49b 100644 --- a/docs/common/guides/jlink_image.adoc +++ b/docs/common/guides/jlink_image.adoc @@ -138,7 +138,7 @@ using the provide === Class Data Sharing (CDS) Archive -Aslo included in the custom image is a Class Data Sharing (CDS) archive that +Also included in the custom image is a Class Data Sharing (CDS) archive that improves your application's startup performance and in-memory footprint. You can learn more about Class Data Sharing in the https://docs.oracle.com/en/java/javase/11/vm/class-data-sharing.html[JDK documentation].